Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 18:19:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove comments when a comment provider is unregistered (#180502)

Browse Source 
Fixes microsoft/vscode-pull-request-github#4566
This commit is contained in:
Alex Ross
2023-04-21 14:36:29 +02:00
committed by GitHub
parent a362f95b9c
commit ca24086170
6 changed files with 38 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/vs/workbench/api/common/extHostComments.ts
View File

@@ -7,7 +7,7 @@ import { asPromise } from 'vs/base/common/async';
import { CancellationToken } from 'vs/base/common/cancellation';
import { debounce } from 'vs/base/common/decorators';
import { Emitter } from 'vs/base/common/event';
import { DisposableStore, IDisposable, MutableDisposable } from 'vs/base/common/lifecycle';
import { DisposableStore, MutableDisposable } from 'vs/base/common/lifecycle';
import { MarshalledId } from 'vs/base/common/marshallingIds';
import { URI, UriComponents } from 'vs/base/common/uri';
import { IRange } from 'vs/editor/common/core/range';
@@ -31,7 +31,7 @@ interface ExtHostComments {
export function createExtHostComments(mainContext: IMainContext, commands: ExtHostCommands, documents: ExtHostDocuments): ExtHostCommentsShape & ExtHostComments {
const proxy = mainContext.getProxy(MainContext.MainThreadComments);
class ExtHostCommentsImpl implements ExtHostCommentsShape, ExtHostComments, IDisposable {
class ExtHostCommentsImpl implements ExtHostCommentsShape, ExtHostComments {
private static handlePool = 0;
@@ -244,9 +244,6 @@ export function createExtHostComments(mainContext: IMainContext, commands: ExtHo
return Promise.resolve(undefined);
});
}
dispose() {
}
}
type CommentThreadModification = Partial<{
range: vscode.Range;