From ca745eea7cb6fd17bb23261ba9344cc018bd0d3d Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Tue, 20 Sep 2022 00:55:06 -0700 Subject: [PATCH] tests - do not `retryCountOnTaskFailure` playwright (#161299) * tests - do not `retryCountOnTaskFailure` playwright * compile --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/monaco-editor.yml | 2 +- build/azure-pipelines/common/installPlaywright.js | 1 + build/azure-pipelines/common/installPlaywright.ts | 2 ++ .../azure-pipelines/darwin/product-build-darwin-test.yml | 4 +--- .../linux/product-build-linux-client-test.yml | 4 +--- build/azure-pipelines/win32/product-build-win32-test.yml | 4 +--- 7 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 84f92eef92b..d505e2b9129 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,7 +69,7 @@ jobs: 7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt - name: Compile and Download - run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions + run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions - name: Compile Integration Tests run: yarn --cwd test/integration/browser compile @@ -145,7 +145,7 @@ jobs: run: yarn --frozen-lockfile --network-timeout 180000 - name: Compile and Download - run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions + run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions - name: Compile Integration Tests run: yarn --cwd test/integration/browser compile @@ -216,7 +216,7 @@ jobs: run: yarn --frozen-lockfile --network-timeout 180000 - name: Compile and Download - run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions + run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions - name: Compile Integration Tests run: yarn --cwd test/integration/browser compile @@ -289,7 +289,7 @@ jobs: run: yarn --frozen-lockfile --network-timeout 180000 - name: Download Playwright - run: DEBUG=pw:install yarn playwright-install + run: yarn playwright-install - name: Run Hygiene Checks run: yarn gulp hygiene diff --git a/.github/workflows/monaco-editor.yml b/.github/workflows/monaco-editor.yml index d6bc1a55e3e..e52713a3e99 100644 --- a/.github/workflows/monaco-editor.yml +++ b/.github/workflows/monaco-editor.yml @@ -53,7 +53,7 @@ jobs: run: yarn --frozen-lockfile --network-timeout 180000 - name: Download Playwright - run: DEBUG=pw:install yarn playwright-install + run: yarn playwright-install - name: Run Monaco Editor Checks run: yarn monaco-compile-check diff --git a/build/azure-pipelines/common/installPlaywright.js b/build/azure-pipelines/common/installPlaywright.js index af4bd5fb54c..06b6312e278 100644 --- a/build/azure-pipelines/common/installPlaywright.js +++ b/build/azure-pipelines/common/installPlaywright.js @@ -4,6 +4,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ Object.defineProperty(exports, "__esModule", { value: true }); +process.env.DEBUG = 'pw:install'; // enable logging for this (https://github.com/microsoft/playwright/issues/17394) const retry_1 = require("./retry"); const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server'); async function install() { diff --git a/build/azure-pipelines/common/installPlaywright.ts b/build/azure-pipelines/common/installPlaywright.ts index 5d837a55413..b62c57798b6 100644 --- a/build/azure-pipelines/common/installPlaywright.ts +++ b/build/azure-pipelines/common/installPlaywright.ts @@ -3,6 +3,8 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ +process.env.DEBUG='pw:install'; // enable logging for this (https://github.com/microsoft/playwright/issues/17394) + import { retry } from './retry'; const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server'); diff --git a/build/azure-pipelines/darwin/product-build-darwin-test.yml b/build/azure-pipelines/darwin/product-build-darwin-test.yml index db9fd21edc5..29c7bf90925 100644 --- a/build/azure-pipelines/darwin/product-build-darwin-test.yml +++ b/build/azure-pipelines/darwin/product-build-darwin-test.yml @@ -12,9 +12,7 @@ steps: - script: | set -e VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \ - DEBUG=pw:install yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" - timeoutInMinutes: 5 - retryCountOnTaskFailure: 3 + yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" displayName: Download Electron and Playwright - ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}: diff --git a/build/azure-pipelines/linux/product-build-linux-client-test.yml b/build/azure-pipelines/linux/product-build-linux-client-test.yml index 2dd36037338..36495873d96 100644 --- a/build/azure-pipelines/linux/product-build-linux-client-test.yml +++ b/build/azure-pipelines/linux/product-build-linux-client-test.yml @@ -12,9 +12,7 @@ steps: - script: | set -e VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \ - DEBUG=pw:install yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" - timeoutInMinutes: 5 - retryCountOnTaskFailure: 3 + yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" displayName: Download Electron and Playwright - ${{ if eq(parameters.VSCODE_QUALITY, 'oss') }}: diff --git a/build/azure-pipelines/win32/product-build-win32-test.yml b/build/azure-pipelines/win32/product-build-win32-test.yml index b3196c537a4..9a17a88bca7 100644 --- a/build/azure-pipelines/win32/product-build-win32-test.yml +++ b/build/azure-pipelines/win32/product-build-win32-test.yml @@ -13,9 +13,7 @@ steps: . build/azure-pipelines/win32/exec.ps1 $ErrorActionPreference = "Stop" $env:VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" - exec { $env:DEBUG = "pw:install"; yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" } - timeoutInMinutes: 5 - retryCountOnTaskFailure: 3 + exec { yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" } displayName: Download Electron and Playwright - ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}: