Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Resolve todos, move process creation after xterm

Browse Source 
Having _processManager.createProcess called before _createXterm was causing
some event listeners like onProcessReady to fire before they were registered
within _createXterm.
This commit is contained in:
Daniel Imms
2020-06-21 08:12:13 -07:00
parent 34b20f9609
commit cb5ddcf44f
6 changed files with 35 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/api/browser/mainThreadTerminalService.ts
View File

@@ -176,7 +176,6 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape
public $startLinkProvider(): void {
this._linkProvider?.dispose();
// TODO: Verify sharing a link provider works fine with removal of intersecting links
this._linkProvider = this._terminalService.registerLinkProvider(new ExtensionTerminalLinkProvider(this._proxy));
}
@@ -432,10 +431,7 @@ class ExtensionTerminalLinkProvider implements ITerminalExternalLinkProvider {
startIndex: dto.startIndex,
length: dto.length,
label: dto.label,
activate(text: string) {
console.log('Activated! ' + text);
proxy.$activateLink(instance.id, dto.id);
}
activate: () => proxy.$activateLink(instance.id, dto.id)
}));
}
}