Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 19:59:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't enable commit characters when isNewIdentifierLocation is true

Browse Source 
Fixes #54386
This commit is contained in:
Matt Bierner
2018-07-16 10:03:59 -07:00
parent 37a59a282a
commit cbcafcc284
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/typescript-language-features/src/features/completions.ts
View File

@@ -21,7 +21,7 @@ const localize = nls.loadMessageBundle();
interface CommitCharactersSettings {
readonly enable: boolean;
readonly enabled: boolean;
readonly enableDotCompletions: boolean;
readonly enableCallCompletions: boolean;
}
@@ -147,6 +147,10 @@ class MyCompletionItem extends vscode.CompletionItem {
@memoize
public get commitCharacters(): string[] | undefined {
if (!this.commitCharactersSettings.enabled) {
return undefined;
}
const commitCharacters: string[] = [];
switch (this.tsEntry.kind) {
case PConst.Kind.memberGetAccessor:
@@ -331,7 +335,7 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider
return msg
.filter(entry => !shouldExcludeCompletionEntry(entry, completionConfiguration))
.map(entry => new MyCompletionItem(position, document, line.text, entry, completionConfiguration.useCodeSnippetsOnMethodSuggest, {
enable: enableCommitCharacters,
enabled: enableCommitCharacters,
enableDotCompletions,
enableCallCompletions: !completionConfiguration.useCodeSnippetsOnMethodSuggest
}));