Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 00:28:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Removal of feedback control (fix #188960) (#189027)

Browse Source
This commit is contained in:
Benjamin Pasero
2023-07-28 10:12:52 +02:00
committed by GitHub
parent 55b75c5504
commit cbdfe4e0b4
15 changed files with 18 additions and 878 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/automation/src/statusbar.ts
View File

@@ -13,8 +13,7 @@ export const enum StatusBarElement {
INDENTATION_STATUS = 4,
ENCODING_STATUS = 5,
EOL_STATUS = 6,
LANGUAGE_STATUS = 7,
FEEDBACK_ICON = 8
LANGUAGE_STATUS = 7
}
export class StatusBar {
@@ -57,8 +56,6 @@ export class StatusBar {
return `.statusbar-item[id="status.editor.eol"]`;
case StatusBarElement.LANGUAGE_STATUS:
return `.statusbar-item[id="status.editor.mode"]`;
case StatusBarElement.FEEDBACK_ICON:
return `.statusbar-item[id="status.feedback"]`;
default:
throw new Error(element);
}

15
test/smoke/src/areas/statusbar/statusbar.test.ts
View File

@@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import { join } from 'path';
import { Application, Quality, StatusBarElement, Logger } from '../../../../automation';
import { Application, StatusBarElement, Logger } from '../../../../automation';
import { installAllHandlers } from '../../utils';
export function setup(logger: Logger) {
@@ -16,9 +16,6 @@ export function setup(logger: Logger) {
it('verifies presence of all default status bar elements', async function () {
const app = this.app as Application;
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.BRANCH_STATUS);
if (app.quality !== Quality.Dev && app.quality !== Quality.OSS) {
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.FEEDBACK_ICON);
}
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.SYNC_STATUS);
await app.workbench.statusbar.waitForStatusbarElement(StatusBarElement.PROBLEMS_STATUS);
@@ -66,15 +63,5 @@ export function setup(logger: Logger) {
await app.workbench.statusbar.waitForEOL('CRLF');
});
it(`verifies that 'Tweet us feedback' pop-up appears when clicking on 'Feedback' icon`, async function () {
const app = this.app as Application;
if (app.quality === Quality.Dev || app.quality === Quality.OSS) {
return this.skip();
}
await app.workbench.statusbar.clickOn(StatusBarElement.FEEDBACK_ICON);
await app.code.waitForElement('.feedback-form');
});
});
}