Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 18:19:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

testing: fix test appearing on first line, remove location from TestItems

Browse Source 
Fixes #119634
This commit is contained in:
Connor Peet
2021-03-24 12:09:45 -07:00
parent 6084989763
commit cd31f2cdfa
17 changed files with 111 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vs/workbench/api/common/extHostTesting.ts
View File

@@ -402,18 +402,13 @@ export class TestItemFilteredWrapper<T extends vscode.TestItem = vscode.TestItem
private filterDocument: vscode.TextDocument,
public readonly parent?: TestItemFilteredWrapper<T>,
) {
super(actual.id, actual.label, actual.expandable);
super(actual.id, actual.label, actual.uri, actual.expandable);
if (!(actual instanceof TestItemImpl)) {
throw new Error(`TestItems provided to the VS Code API must extend \`vscode.TestItem\`, but ${actual.id} did not`);
}
(actual as TestItemImpl)[TestItemHookProperty] = {
setProp: (key, value) => {
(this as Record<string, unknown>)[key] = value;
if (key === 'location') {
this.refreshMatch();
}
},
setProp: (key, value) => (this as Record<string, unknown>)[key] = value,
created: child => TestItemFilteredWrapper.getWrapperForTestItem(child, this.filterDocument, this).refreshMatch(),
invalidate: () => this.invalidate(),
delete: child => this.children.delete(child),
@@ -439,7 +434,7 @@ export class TestItemFilteredWrapper<T extends vscode.TestItem = vscode.TestItem
}
}
const nowMatches = this.children.size > 0 || this.actual.location?.uri.toString() === this.filterDocument.uri.toString();
const nowMatches = this.children.size > 0 || this.actual.uri.toString() === this.filterDocument.uri.toString();
this._cachedMatchesFilter = nowMatches;
if (nowMatches !== didMatch) {