From ce15d8c355a2591bd6c2a850fca4df14cf0b05ab Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 13 Aug 2018 16:31:41 +0200 Subject: [PATCH] uri - print a warning when an URI lacks a scheme, #56108 --- src/vs/base/common/uri.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/vs/base/common/uri.ts b/src/vs/base/common/uri.ts index 4a6f69ea626..00d663cd507 100644 --- a/src/vs/base/common/uri.ts +++ b/src/vs/base/common/uri.ts @@ -13,10 +13,11 @@ const _doubleSlashStart = /^\/\//; function _validateUri(ret: URI): void { - // // scheme, must be set - // if (!ret.scheme) { - // throw new Error('[UriError]: Scheme is missing.'); - // } + // scheme, must be set + if (!ret.scheme) { + // throw new Error(`[UriError]: Scheme is missing: {scheme: "", authority: "${ret.authority}", path: "${ret.path}", query: "${ret.query}", fragment: "${ret.fragment}"}`); + console.warn(`[UriError]: Scheme is missing: {scheme: "", authority: "${ret.authority}", path: "${ret.path}", query: "${ret.query}", fragment: "${ret.fragment}"}`); + } // scheme, https://tools.ietf.org/html/rfc3986#section-3.1 // ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )