Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

- add tests

Browse Source 
- fix scenarios causing tests failures
- check for duplicate policy names
This commit is contained in:
Sandeep Somavarapu
2022-05-11 16:16:11 +02:00
parent d4a3656ab3
commit ce60d548e2
10 changed files with 351 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/api/common/configurationExtensionPoint.ts
View File

@@ -204,7 +204,8 @@ configurationExtPoint.setHandler((extensions, { added, removed }) => {
configuration.properties = {};
}
for (let key in properties) {
const message = validateProperty(key);
const propertyConfiguration = properties[key];
const message = validateProperty(key, propertyConfiguration);
if (message) {
delete properties[key];
extension.collector.warn(message);
@@ -215,7 +216,6 @@ configurationExtPoint.setHandler((extensions, { added, removed }) => {
extension.collector.warn(nls.localize('config.property.duplicate', "Cannot register '{0}'. This property is already registered.", key));
continue;
}
const propertyConfiguration = properties[key];
if (!isObject(propertyConfiguration)) {
delete properties[key];
extension.collector.error(nls.localize('invalid.property', "configuration.properties property '{0}' must be an object", key));