Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 00:59:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Secrets API feedback

Browse Source
This commit is contained in:
Rachel Macfarlane
2021-01-05 10:16:50 -08:00
parent 037708a33f
commit ced3bb4bb9
7 changed files with 19 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/github-authentication/src/common/keychain.ts
View File

@@ -34,7 +34,7 @@ export class Keychain {
constructor(private context: vscode.ExtensionContext) { }
async setToken(token: string): Promise<void> {
try {
return await this.context.secretState.set(SERVICE_ID, token);
return await this.context.secrets.set(SERVICE_ID, token);
} catch (e) {
// Ignore
Logger.error(`Setting token failed: ${e}`);
@@ -48,7 +48,7 @@ export class Keychain {
async getToken(): Promise<string | null | undefined> {
try {
return await this.context.secretState.get(SERVICE_ID);
return await this.context.secrets.get(SERVICE_ID);
} catch (e) {
// Ignore
Logger.error(`Getting token failed: ${e}`);
@@ -58,7 +58,7 @@ export class Keychain {
async deleteToken(): Promise<void> {
try {
return await this.context.secretState.delete(SERVICE_ID);
return await this.context.secrets.delete(SERVICE_ID);
} catch (e) {
// Ignore
Logger.error(`Deleting token failed: ${e}`);

2
extensions/github-authentication/src/github.ts
View File

@@ -40,7 +40,7 @@ export class GitHubAuthenticationProvider {
// Ignore, network request failed
}
context.subscriptions.push(context.secretState.onDidChange(() => this.checkForUpdates()));
context.subscriptions.push(context.secrets.onDidChange(() => this.checkForUpdates()));
}
private async verifySessions(): Promise<void> {