Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 14:31:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't send custom editor edit events to extension host for non-editable custom editors

Browse Source
This commit is contained in:
Matt Bierner
2020-03-04 13:36:22 -08:00
parent 466f7166b8
commit cf086f01bd
1 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/vs/workbench/api/browser/mainThreadWebview.ts
View File

@@ -604,18 +604,27 @@ class MainThreadCustomEditorModel extends Disposable implements ICustomEditorMod
}
public async revert(_options?: IRevertOptions) {
this._proxy.$revert(this.resource, this.viewType);
if (this._editable) {
this._proxy.$revert(this.resource, this.viewType);
}
}
public undo() {
this._proxy.$undo(this.resource, this.viewType);
if (this._editable) {
this._proxy.$undo(this.resource, this.viewType);
}
}
public redo() {
this._proxy.$redo(this.resource, this.viewType);
if (this._editable) {
this._proxy.$redo(this.resource, this.viewType);
}
}
public async save(_options?: ISaveOptions): Promise<boolean> {
if (!this._editable) {
return false;
}
await this._proxy.$onSave(this.resource, this.viewType);
this.setDirty(false);
return true;
@@ -634,6 +643,16 @@ class MainThreadCustomEditorModel extends Disposable implements ICustomEditorMod
}
public async backup(): Promise<IWorkingCopyBackup> {
const backupData: IWorkingCopyBackup = {
meta: {
viewType: this.viewType,
}
};
if (!this._editable) {
return backupData;
}
if (this._hotExitState.type === HotExitState.Type.Pending) {
this._hotExitState.operation.cancel();
}
@@ -657,11 +676,7 @@ class MainThreadCustomEditorModel extends Disposable implements ICustomEditorMod
}
if (this._hotExitState === HotExitState.Allowed) {
return {
meta: {
viewType: this.viewType,
}
};
return backupData;
}
throw new Error('Cannot back up in this state');