Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-18 15:55:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove region diagnostics setting

Browse Source 
Part of #292934

This is an implementation detail. Was only really added in 5.6 in case the new behavior caused issues. Should be safe to remove now
This commit is contained in:
Matt Bierner
2026-02-04 14:44:40 -08:00
parent 38398d6453
commit cfbd57afa6
4 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript-language-features/src/configuration/configuration.ts
View File

@@ -133,7 +133,6 @@ export interface TypeScriptServiceConfiguration {
readonly localNodePath: string | null;
readonly globalNodePath: string | null;
readonly workspaceSymbolsExcludeLibrarySymbols: boolean;
readonly enableRegionDiagnostics: boolean;
}
export function areServiceConfigurationsEqual(a: TypeScriptServiceConfiguration, b: TypeScriptServiceConfiguration): boolean {
@@ -176,7 +175,6 @@ export abstract class BaseServiceConfigurationProvider implements ServiceConfigu
localNodePath: this.readLocalNodePath(configuration),
globalNodePath: this.readGlobalNodePath(configuration),
workspaceSymbolsExcludeLibrarySymbols: this.readWorkspaceSymbolsExcludeLibrarySymbols(configuration),
enableRegionDiagnostics: this.readEnableRegionDiagnostics(configuration),
};
}
@@ -307,8 +305,4 @@ export abstract class BaseServiceConfigurationProvider implements ServiceConfigu
private readWebTypeAcquisition(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('typescript.tsserver.web.typeAcquisition.enabled', true);
}
private readEnableRegionDiagnostics(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('typescript.tsserver.enableRegionDiagnostics', true);
}
}

2
extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts
View File

@@ -354,7 +354,7 @@ class GetErrRequest {
}
private areRegionDiagnosticsEnabled(): boolean {
return this.client.configuration.enableRegionDiagnostics && this.client.apiVersion.gte(API.v560);
return this.client.apiVersion.gte(API.v560);
}
public cancel(): void {