From d0f0de52df33dd699eea0eb1144dce53d038c94a Mon Sep 17 00:00:00 2001 From: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Mon, 8 Jul 2024 09:14:50 +0200 Subject: [PATCH] Git - fix commit flow regression (#220991) --- extensions/git/src/commands.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/extensions/git/src/commands.ts b/extensions/git/src/commands.ts index 55c5f89fd3ab..686ce366e293 100644 --- a/extensions/git/src/commands.ts +++ b/extensions/git/src/commands.ts @@ -2063,7 +2063,7 @@ export class CommandCenter { promptToSaveFilesBeforeCommit = 'never'; } - const enableSmartCommit = config.get('enableSmartCommit') === true; + let enableSmartCommit = config.get('enableSmartCommit') === true; const enableCommitSigning = config.get('enableCommitSigning') === true; let noStagedChanges = repository.indexGroup.resourceStates.length === 0; let noUnstagedChanges = repository.workingTreeGroup.resourceStates.length === 0; @@ -2119,12 +2119,16 @@ export class CommandCenter { const pick = await window.showWarningMessage(message, { modal: true }, yes, always, never); if (pick === always) { + enableSmartCommit = true; config.update('enableSmartCommit', true, true); } else if (pick === never) { config.update('suggestSmartCommit', false, true); return; - } else if (pick !== yes) { - return; // do not commit on cancel + } else if (pick === yes) { + enableSmartCommit = true; + } else { + // Cancel + return; } }