diff --git a/src/vs/platform/telemetry/common/gdprTypings.ts b/src/vs/platform/telemetry/common/gdprTypings.ts index d014944112a..316c84fca8d 100644 --- a/src/vs/platform/telemetry/common/gdprTypings.ts +++ b/src/vs/platform/telemetry/common/gdprTypings.ts @@ -13,16 +13,11 @@ export interface IPropertyData { } export interface IGDPRProperty { - owner?: string; - comment?: string; - expiration?: string; - readonly [name: string]: IPropertyData | undefined | IGDPRProperty | string; + readonly [name: string]: IPropertyData | undefined | IGDPRProperty; } -export type IGDPRPropertyWithoutMetadata = Omit; - export type ClassifiedEvent = { - [k in keyof IGDPRPropertyWithoutMetadata]: any + [k in keyof T]: any }; export type StrictPropertyChecker = keyof TEvent extends keyof TClassifiedEvent ? keyof TClassifiedEvent extends keyof TEvent ? TEvent : TError : TError; @@ -31,4 +26,4 @@ export type StrictPropertyCheckError = 'Type of classified event does not match export type StrictPropertyCheck = StrictPropertyChecker, StrictPropertyCheckError>; -export type GDPRClassification = { [_ in keyof T]: IPropertyData | IGDPRProperty | undefined | string }; +export type GDPRClassification = { [_ in keyof T]: IPropertyData | IGDPRProperty | undefined }; diff --git a/src/vs/workbench/api/browser/mainThreadTelemetry.ts b/src/vs/workbench/api/browser/mainThreadTelemetry.ts index 6e13fa13053..58a919fc1e6 100644 --- a/src/vs/workbench/api/browser/mainThreadTelemetry.ts +++ b/src/vs/workbench/api/browser/mainThreadTelemetry.ts @@ -55,7 +55,7 @@ export class MainThreadTelemetry extends Disposable implements MainThreadTelemet this._telemetryService.publicLog(eventName, data); } - $publicLog2 = never, T extends GDPRClassification = never>(eventName: string, data?: StrictPropertyCheck): void { + $publicLog2 = never, T extends GDPRClassification = never>(eventName: string, data: StrictPropertyCheck): void { this.$publicLog(eventName, data as any); } } diff --git a/src/vs/workbench/services/editor/browser/editorResolverService.ts b/src/vs/workbench/services/editor/browser/editorResolverService.ts index 9e6f8db55e6..9edd90ea440 100644 --- a/src/vs/workbench/services/editor/browser/editorResolverService.ts +++ b/src/vs/workbench/services/editor/browser/editorResolverService.ts @@ -746,9 +746,7 @@ export class EditorResolverService extends Disposable implements IEditorResolver private sendEditorResolutionTelemetry(chosenInput: EditorInput): void { type editorResolutionClassification = { - viewType: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight'; comment: 'The id of the editor opened. Used to gain an undertsanding of what editors are most popular' }; - owner: 'lramos15'; - comment: 'Event sent when an editor type is determined.'; + viewType: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight'; owner: 'lramos15'; comment: 'The id of the editor opened. Used to gain an undertsanding of what editors are most popular' }; }; type editorResolutionEvent = { viewType: string;