Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 09:08:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we dispose/track disposed webviews in webview views

Browse Source 
Fixes #106826
This commit is contained in:
Matt Bierner
2020-09-16 15:33:10 -07:00
parent 4799714403
commit d29fc5038a
3 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/api/common/extHostWebview.ts
View File

@@ -54,6 +54,8 @@ export class ExtHostWebview implements vscode.Webview {
/* internal */ readonly _onDidDispose: Event<void> = this.#onDidDisposeEmitter.event;
public dispose() {
this.#isDisposed = true;
this.#onDidDisposeEmitter.fire();
this.#onDidDisposeEmitter.dispose();
@@ -99,8 +101,10 @@ export class ExtHostWebview implements vscode.Webview {
this.#options = newOptions;
}
public postMessage(message: any): Promise<boolean> {
this.assertNotDisposed();
public async postMessage(message: any): Promise<boolean> {
if (this.#isDisposed) {
return false;
}
return this.#proxy.$postMessage(this.#handle, message);
}