Make sure we dispose/track disposed webviews in webview views

Fixes #106826
This commit is contained in:
Matt Bierner
2020-09-16 15:33:10 -07:00
parent 4799714403
commit d29fc5038a
3 changed files with 12 additions and 2 deletions

View File

@@ -51,6 +51,8 @@ class ExtHostWebviewView extends Disposable implements vscode.WebviewView {
this.#isDisposed = true;
this.#onDidDispose.fire();
this.#webview.dispose();
super.dispose();
}
@@ -186,6 +188,8 @@ export class ExtHostWebviewViews implements extHostProtocol.ExtHostWebviewViewsS
const webviewView = this.getWebviewView(webviewHandle);
this._webviewViews.delete(webviewHandle);
webviewView.dispose();
this._extHostWebview.deleteWebview(webviewHandle);
}
private getWebviewView(handle: string): ExtHostWebviewView {