From d2d60bcc33da4eb58638fdcb9d414a93fb77e58c Mon Sep 17 00:00:00 2001 From: Martin Aeschlimann Date: Mon, 18 Nov 2024 14:16:14 +0100 Subject: [PATCH] Icon font size in label is to small (#234088) --- src/vs/base/browser/cssValue.ts | 4 ++-- src/vs/workbench/services/themes/browser/fileIconThemeData.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/base/browser/cssValue.ts b/src/vs/base/browser/cssValue.ts index f099ead8ce0..d30a7747be2 100644 --- a/src/vs/base/browser/cssValue.ts +++ b/src/vs/base/browser/cssValue.ts @@ -65,9 +65,9 @@ export function asCSSUrl(uri: URI | null | undefined): CssFragment { return inline`url(${stringValue(FileAccess.uriToBrowserUri(uri).toString(true))})`; } -export function className(value: string): CssFragment { +export function className(value: string, escapingExcected = false): CssFragment { const out = CSS.escape(value); - if (out !== value) { + if (!escapingExcected && out !== value) { console.warn(`CSS class name ${value} modified to ${out} to be safe for CSS`); } return asFragment(out); diff --git a/src/vs/workbench/services/themes/browser/fileIconThemeData.ts b/src/vs/workbench/services/themes/browser/fileIconThemeData.ts index 79bebd3ad1c..c60faca2144 100644 --- a/src/vs/workbench/services/themes/browser/fileIconThemeData.ts +++ b/src/vs/workbench/services/themes/browser/fileIconThemeData.ts @@ -407,7 +407,7 @@ export class FileIconThemeLoader { fontSizes.set(font.id, fontSize); } }); - cssRules.push(css.inline`.show-file-icons .file-icon::before, .show-file-icons .folder-icon::before, .show-file-icons .rootfolder-icon::before { font-family: ${css.stringValue(fonts[0].id)}; font-size: ${css.identValue(defaultFontSize)}; }`); + cssRules.push(css.inline`.show-file-icons .file-icon::before, .show-file-icons .folder-icon::before, .show-file-icons .rootfolder-icon::before { font-family: ${css.stringValue(fonts[0].id)}; font-size: ${css.sizeValue(defaultFontSize)}; }`); } // Use emQuads to prevent the icon from collapsing to zero height for image icons @@ -494,5 +494,5 @@ function handleParentFolder(key: string, selectors: css.Builder): string { function classSelectorPart(str: string): css.CssFragment { str = fileIconSelectorEscape(str); - return css.className(str); + return css.className(str, true); }