Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Review uses of Promise.resolve(null)

Browse Source 
Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.
This commit is contained in:
Matt Bierner
2018-12-13 15:41:13 -08:00
parent 68a4e01246
commit d40fa4a27e
48 changed files with 109 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/api/electron-browser/mainThreadEditors.ts
View File

@@ -166,7 +166,7 @@ export class MainThreadTextEditors implements MainThreadTextEditorsShape {
return Promise.reject(disposed(`TextEditor(${id})`));
}
this._documentsAndEditors.getEditor(id).setSelections(selections);
return Promise.resolve(null);
return Promise.resolve(void 0);
}
$trySetDecorations(id: string, key: string, ranges: IDecorationOptions[]): Promise<void> {
@@ -175,7 +175,7 @@ export class MainThreadTextEditors implements MainThreadTextEditorsShape {
return Promise.reject(disposed(`TextEditor(${id})`));
}
this._documentsAndEditors.getEditor(id).setDecorations(key, ranges);
return Promise.resolve(null);
return Promise.resolve(void 0);
}
$trySetDecorationsFast(id: string, key: string, ranges: number[]): Promise<void> {
@@ -184,7 +184,7 @@ export class MainThreadTextEditors implements MainThreadTextEditorsShape {
return Promise.reject(disposed(`TextEditor(${id})`));
}
this._documentsAndEditors.getEditor(id).setDecorationsFast(key, ranges);
return Promise.resolve(null);
return Promise.resolve(void 0);
}
$tryRevealRange(id: string, range: IRange, revealType: TextEditorRevealType): Promise<void> {
@@ -200,7 +200,7 @@ export class MainThreadTextEditors implements MainThreadTextEditorsShape {
return Promise.reject(disposed(`TextEditor(${id})`));
}
this._documentsAndEditors.getEditor(id).setConfiguration(options);
return Promise.resolve(null);
return Promise.resolve(void 0);
}
$tryApplyEdits(id: string, modelVersionId: number, edits: ISingleEditOperation[], opts: IApplyEditsOptions): Promise<boolean> {