Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 16:49:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove CustomDocument.viewType

Browse Source 
Fixes #93867
For #77131

This property is no longer needed (or very helpful) with the current api design
This commit is contained in:
Matt Bierner
2020-03-31 11:28:41 -07:00
parent 0d351bd55f
commit d41997790c
5 changed files with 12 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/vs/workbench/api/common/extHostWebview.ts
View File

@@ -269,16 +269,16 @@ class WebviewDocumentStore {
return this._documents.get(this.key(viewType, resource));
}
public add(document: extHostTypes.CustomDocument) {
const key = this.key(document.viewType, document.uri);
public add(viewType: string, document: extHostTypes.CustomDocument) {
const key = this.key(viewType, document.uri);
if (this._documents.has(key)) {
throw new Error(`Document already exists for viewType:${document.viewType} resource:${document.uri}`);
throw new Error(`Document already exists for viewType:${viewType} resource:${document.uri}`);
}
this._documents.set(key, document);
}
public delete(document: extHostTypes.CustomDocument) {
const key = this.key(document.viewType, document.uri);
public delete(viewType: string, document: extHostTypes.CustomDocument) {
const key = this.key(viewType, document.uri);
this._documents.delete(key);
}
@@ -414,7 +414,7 @@ export class ExtHostWebviews implements extHostProtocol.ExtHostWebviewsShape {
disposables.add(provider.editingDelegate.onDidEdit(e => {
const document = e.document;
const editId = (document as extHostTypes.CustomDocument)._addEdit(e.edit);
this._proxy.$onDidEdit(document.uri, document.viewType, editId, e.label);
this._proxy.$onDidEdit(document.uri, viewType, editId, e.label);
}));
}
}
@@ -516,7 +516,7 @@ export class ExtHostWebviews implements extHostProtocol.ExtHostWebviewsShape {
const revivedResource = URI.revive(resource);
const document = await entry.provider.openCustomDocument(revivedResource, cancellation);
this._documents.add(document as extHostTypes.CustomDocument);
this._documents.add(viewType, document as extHostTypes.CustomDocument);
return {
editable: !!entry.provider.editingDelegate,
};
@@ -534,7 +534,7 @@ export class ExtHostWebviews implements extHostProtocol.ExtHostWebviewsShape {
const revivedResource = URI.revive(resource);
const document = this.getCustomDocument(viewType, revivedResource);
this._documents.delete(document);
this._documents.delete(viewType, document);
document._dispose();
}