From d43d4da7d48ea4b455a18fcf54d3a025d01fb58a Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu, 1 Jan 2026 08:42:37 -0800 Subject: [PATCH] Share single stat call --- .../suggest/browser/terminalCompletionService.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts b/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts index a449bb45afed..bf819a3c6d75 100644 --- a/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts +++ b/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts @@ -411,7 +411,10 @@ export class TerminalCompletionService extends Disposable implements ITerminalCo return resourceCompletions; } - const stat = await this._fileService.resolve(lastWordFolderResource, { resolveSingleChildDescendants: true }); + const stat = await this._fileService.resolve(lastWordFolderResource, { + resolveMetadata: true, + resolveSingleChildDescendants: true + }); if (!stat?.children) { return; } @@ -475,12 +478,7 @@ export class TerminalCompletionService extends Disposable implements ITerminalCo } else if (showFiles && child.isFile) { // When completing the command (first word) on Unix, only show executable files if (isCommandPosition && !useWindowsStylePath) { - try { - const childStat = await this._fileService.stat(child.resource); - if (!childStat.executable) { - return; - } - } catch { + if (!child.executable) { return; } }