Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-01 05:51:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove need for acquiring dimensions for terminal from main thread

Browse Source
This commit is contained in:
Gabriel DeBacker
2019-03-06 11:47:57 -08:00
parent 99cf5e4881
commit d5e4009ae9
5 changed files with 40 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts
View File

@@ -118,15 +118,6 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape
}
}
public $terminalGetDimensions(terminalId: number): Promise<ITerminalDimensions> {
const terminalInstance = this.terminalService.getInstanceFromId(terminalId);
if (terminalInstance && terminalInstance.shellLaunchConfig.isRendererOnly) {
return Promise.resolve({ cols: terminalInstance.cols, rows: terminalInstance.rows });
}
return Promise.reject(new Error('Dimensions cannot be retrieved'));
}
public $terminalRendererSetDimensions(terminalId: number, dimensions: ITerminalDimensions): void {
const terminalInstance = this.terminalService.getInstanceFromId(terminalId);
if (terminalInstance && terminalInstance.shellLaunchConfig.isRendererOnly) {
@@ -197,10 +188,10 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape
private _onTerminalOpened(terminalInstance: ITerminalInstance): void {
if (terminalInstance.title) {
this._proxy.$acceptTerminalOpened(terminalInstance.id, terminalInstance.title, !!terminalInstance.shellLaunchConfig.isRendererOnly, terminalInstance.cols, terminalInstance.rows);
this._proxy.$acceptTerminalOpened(terminalInstance.id, terminalInstance.title);
} else {
terminalInstance.waitForTitle().then(title => {
this._proxy.$acceptTerminalOpened(terminalInstance.id, title, !!terminalInstance.shellLaunchConfig.isRendererOnly, terminalInstance.cols, terminalInstance.rows);
this._proxy.$acceptTerminalOpened(terminalInstance.id, title);
});
}
}