Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-29 13:03:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

When the remote extension host disconnects, ask the server if it actually just crashed (using the management connection)

Browse Source
This commit is contained in:
Alex Dima
2022-03-21 16:13:51 +01:00
parent 0a644fc765
commit d61e2520e0
14 changed files with 171 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/vs/server/node/extensionHostConnection.ts
View File

@@ -20,6 +20,7 @@ import { IServerEnvironmentService } from 'vs/server/node/serverEnvironmentServi
import { IProcessEnvironment, isWindows } from 'vs/base/common/platform';
import { logRemoteEntry } from 'vs/workbench/services/extensions/common/remoteConsoleUtil';
import { removeDangerousEnvVariables } from 'vs/base/node/processes';
import { IExtensionHostStatusService } from 'vs/server/node/extensionHostStatusService';
export async function buildUserEnvironment(startParamsEnv: { [key: string]: string | null } = {}, withUserShellEnvironment: boolean, language: string, isDebug: boolean, environmentService: IServerEnvironmentService, logService: ILogService): Promise<IProcessEnvironment> {
const nlsConfig = await getNLSConfiguration(language, environmentService.userDataPath);
@@ -102,12 +103,13 @@ export class ExtensionHostConnection {
private _connectionData: ConnectionData | null;
constructor(
private readonly _environmentService: IServerEnvironmentService,
private readonly _logService: ILogService,
private readonly _reconnectionToken: string,
remoteAddress: string,
socket: NodeSocket | WebSocketNodeSocket,
initialDataChunk: VSBuffer
initialDataChunk: VSBuffer,
@IServerEnvironmentService private readonly _environmentService: IServerEnvironmentService,
@ILogService private readonly _logService: ILogService,
@IExtensionHostStatusService private readonly _extensionHostStatusService: IExtensionHostStatusService,
) {
this._disposed = false;
this._remoteAddress = remoteAddress;
@@ -233,6 +235,7 @@ export class ExtensionHostConnection {
});
this._extensionHostProcess.on('exit', (code: number, signal: string) => {
this._extensionHostStatusService.setExitInfo(this._reconnectionToken, { code, signal });
this._log(`<${pid}> Extension Host Process exited with code: ${code}, signal: ${signal}.`);
this._cleanResources();
});