Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 14:31:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

notebooks: improve renderer message passing

Browse Source 
Fixes https://github.com/microsoft/vscode/issues/122944
This commit is contained in:
Connor Peet
2021-05-04 12:25:08 -07:00
parent 51dbb570e9
commit d639345791
8 changed files with 85 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/vs/workbench/api/browser/mainThreadNotebookKernels.ts
View File

@@ -122,9 +122,6 @@ export class MainThreadNotebookKernels implements MainThreadNotebookKernelsShape
private _onEditorAdd(editor: INotebookEditor) {
const ipcListener = editor.onDidReceiveMessage(e => {
if (e.forRenderer) {
return;
}
if (!editor.hasModel()) {
return;
}
@@ -134,7 +131,7 @@ export class MainThreadNotebookKernels implements MainThreadNotebookKernelsShape
}
for (let [handle, candidate] of this._kernels) {
if (candidate[0] === selected) {
this._proxy.$acceptRendererMessage(handle, editor.getId(), e.message);
this._proxy.$acceptKernelMessageFromRenderer(handle, editor.getId(), e.message);
break;
}
}
@@ -164,11 +161,11 @@ export class MainThreadNotebookKernels implements MainThreadNotebookKernelsShape
}
if (editorId === undefined) {
// all editors
editor.postMessage(undefined, message);
editor.postMessage(message);
didSend = true;
} else if (editor.getId() === editorId) {
// selected editors
editor.postMessage(undefined, message);
editor.postMessage(message);
didSend = true;
break;
}