From d7c0fbe2bfde360a113dd680349d4de85acf1a31 Mon Sep 17 00:00:00 2001 From: rebornix Date: Fri, 28 Jul 2017 15:14:27 -0700 Subject: [PATCH] Fix #31686. Hover should dismissed if the mouse down is not in the hover widget --- src/vs/editor/contrib/hover/browser/hover.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/editor/contrib/hover/browser/hover.ts b/src/vs/editor/contrib/hover/browser/hover.ts index 699102e1c6e..c895d1c9888 100644 --- a/src/vs/editor/contrib/hover/browser/hover.ts +++ b/src/vs/editor/contrib/hover/browser/hover.ts @@ -106,7 +106,7 @@ export class ModesHoverController implements editorCommon.IEditorContribution { var targetType = mouseEvent.target.type; var stopKey = platform.isMacintosh ? 'metaKey' : 'ctrlKey'; - if (this._isMouseDown || (this._hoverClicked && this._contentWidget.isColorPickerVisible())) { + if (this._isMouseDown && this._hoverClicked && this._contentWidget.isColorPickerVisible()) { return; } @@ -139,7 +139,7 @@ export class ModesHoverController implements editorCommon.IEditorContribution { } private _hideWidgets(): void { - if (this._isMouseDown) { + if (this._isMouseDown && this._hoverClicked && this._contentWidget.isColorPickerVisible()) { return; }