Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix spdlog service not closing file handle on reload

Browse Source 
related to #39659
This commit is contained in:
Joao Moreno
2017-12-05 17:53:50 +01:00
parent 65cd84391d
commit d8cacdc1fd
9 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/node/extensionHostMain.ts
View File

@@ -25,6 +25,7 @@ import { ExtensionActivatedByEvent } from 'vs/workbench/api/node/extHostExtensio
import { EnvironmentService } from 'vs/platform/environment/node/environmentService';
import { SpdLogService } from 'vs/platform/log/node/spdlogService';
import { registerGlobalLogService } from 'vs/platform/log/common/log';
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
// const nativeExit = process.exit.bind(process);
function patchProcess(allowExit: boolean) {
@@ -76,6 +77,7 @@ export class ExtensionHostMain {
private _environment: IEnvironment;
private _extensionService: ExtHostExtensionService;
private _extHostConfiguration: ExtHostConfiguration;
private disposables: IDisposable[] = [];
constructor(rpcProtocol: RPCProtocol, initData: IInitData) {
this._environment = initData.environment;
@@ -89,7 +91,9 @@ export class ExtensionHostMain {
const extHostWorkspace = new ExtHostWorkspace(threadService, initData.workspace);
const environmentService = new EnvironmentService(initData.args, initData.execPath);
const logService = new SpdLogService(`exthost${initData.windowId}`, environmentService);
registerGlobalLogService(logService);
this.disposables.push(logService);
logService.info('main {0}', initData);
@@ -146,6 +150,8 @@ export class ExtensionHostMain {
}
this._isTerminating = true;
this.disposables = dispose(this.disposables);
errors.setUnexpectedErrorHandler((err) => {
// TODO: write to log once we have one
});