Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix line comment action for makefiles (Fixes #234464) (#243283)

Browse Source 
* Fix line comment action for makefiles (Fixes #234464)

Pass languageId to _analyzeLines to distinguish makefiles
from the rest of the languages.

Add test to _analyzeLines specifically for makefiles.

* Remove hardcoded string. Apply fix at LanguageConfigurationService. Add comment rule to specify fixed column token placement. Change test scope to test line command instead of just testing the _analyzeLines method.

* change added field to use bool instead of user-chosen offset

* add check to remove comment detection

* add check to following space removal

* update branch. add config interface for new noindent option. adapt existing logic for new config format.

* fix small issue with following space removal

* polish

---------

Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
This commit is contained in:
Enzo Nunes
2025-06-06 10:22:37 +01:00
committed by GitHub
parent 2685e2a6b3
commit d9145a291d
7 changed files with 109 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/make/language-configuration.json
View File

@@ -1,6 +1,9 @@
{
"comments": {
"lineComment": "#"
"lineComment": {
"comment": "#",
"noIndent": true
}
},
"brackets": [
[