Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add owners to all telemetry events (#150296)

Browse Source
This commit is contained in:
Logan Ramos
2022-05-24 14:58:08 -04:00
committed by GitHub
parent a88075a847
commit d937389358
47 changed files with 85 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vs/workbench/api/common/extHostExtensionService.ts
View File

@@ -424,6 +424,7 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
private _logExtensionActivationTimes(extensionDescription: IExtensionDescription, reason: ExtensionActivationReason, outcome: string, activationTimes?: ExtensionActivationTimes) {
const event = getTelemetryActivationEvent(extensionDescription, reason);
type ExtensionActivationTimesClassification = {
owner: 'jrieken';
outcome: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
} & TelemetryActivationEventFragment & ExtensionActivationTimesFragment;
@@ -447,7 +448,9 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
private _doActivateExtension(extensionDescription: IExtensionDescription, reason: ExtensionActivationReason): Promise<ActivatedExtension> {
const event = getTelemetryActivationEvent(extensionDescription, reason);
type ActivatePluginClassification = {} & TelemetryActivationEventFragment;
type ActivatePluginClassification = {
owner: 'jrieken';
} & TelemetryActivationEventFragment;
this._mainThreadTelemetryProxy.$publicLog2<TelemetryActivationEvent, ActivatePluginClassification>('activatePlugin', event);
const entryPoint = this._getEntryPoint(extensionDescription);
if (!entryPoint) {

3
src/vs/workbench/api/common/extHostRequireInterceptor.ts
View File

@@ -249,6 +249,7 @@ class KeytarNodeModuleFactory implements INodeModuleFactory {
public load(_request: string, parent: URI): any {
const ext = this._extensionPaths.findSubstr(parent);
type ShimmingKeytarClassification = {
owner: 'jrieken';
extension: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
};
this._mainThreadTelemetry.$publicLog2<{ extension: string }, ShimmingKeytarClassification>('shimming.keytar', { extension: ext?.identifier.value ?? 'unknown_extension' });
@@ -346,6 +347,7 @@ class OpenNodeModuleFactory implements INodeModuleFactory {
return;
}
type ShimmingOpenClassification = {
owner: 'jrieken';
extension: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
};
this._mainThreadTelemetry.$publicLog2<{ extension: string }, ShimmingOpenClassification>('shimming.open', { extension: this._extensionId });
@@ -356,6 +358,7 @@ class OpenNodeModuleFactory implements INodeModuleFactory {
return;
}
type ShimmingOpenCallNoForwardClassification = {
owner: 'jrieken';
extension: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
};
this._mainThreadTelemetry.$publicLog2<{ extension: string }, ShimmingOpenCallNoForwardClassification>('shimming.open.call.noForward', { extension: this._extensionId });

5
src/vs/workbench/api/common/extHostSCM.ts
View File

@@ -741,7 +741,10 @@ export class ExtHostSCM implements ExtHostSCMShape {
this.logService.trace('ExtHostSCM#createSourceControl', extension.identifier.value, id, label, rootUri);
type TEvent = { extensionId: string };
type TMeta = { extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' } };
type TMeta = {
owner: 'joaomoreno';
extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
};
this._telemetry.$publicLog2<TEvent, TMeta>('api/scm/createSourceControl', {
extensionId: extension.identifier.value,
});