Implements code-no-observable-get-in-reactive-context (#267526)

* Implements code-no-observable-get-in-reactive-context

* Improves code

* Fixes lint warnings
This commit is contained in:
Henning Dieterichs
2025-09-20 11:29:58 -07:00
committed by GitHub
parent b20a91e37a
commit dace6b32b3
23 changed files with 399 additions and 51 deletions

View File

@@ -1368,7 +1368,7 @@ export class InlineChatController2 implements IEditorContribution {
}
let foundOne = false;
for (const editor of codeEditorService.listCodeEditors()) {
if (Boolean(InlineChatController2.get(editor)?._isActiveController.get())) {
if (Boolean(InlineChatController2.get(editor)?._isActiveController.read(undefined))) {
foundOne = true;
break;
}
@@ -1457,7 +1457,7 @@ export class InlineChatController2 implements IEditorContribution {
this._zone.value.widget.updateToolbar(true);
const entry = session.editingSession.getEntry(session.uri);
entry?.autoAcceptController.get()?.cancel();
entry?.autoAcceptController.read(undefined)?.cancel();
const requestCount = observableFromEvent(this, session.chatModel.onDidChange, () => session.chatModel.getRequests().length).read(r);
this._zone.value.widget.updateToolbar(requestCount > 0);