Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Issue Reporter: display message if url length exceeds limits, #42603

Browse Source
This commit is contained in:
Rachel Macfarlane
2018-02-01 20:06:56 -08:00
parent 9e010775f2
commit db9dc63a85
4 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/vs/code/electron-browser/issue/issueReporterMain.ts
View File

@@ -435,7 +435,18 @@ export class IssueReporter extends Disposable {
const queryStringPrefix = product.reportIssueUrl.indexOf('?') === -1 ? '?' : '&';
const baseUrl = `${product.reportIssueUrl}${queryStringPrefix}title=${issueTitle}&body=`;
const issueBody = this.issueReporterModel.serialize();
shell.openExternal(baseUrl + encodeURIComponent(issueBody));
const url = baseUrl + encodeURIComponent(issueBody);
const lengthValidationElement = document.getElementById('url-length-validation-error');
if (url.length > 2081) {
lengthValidationElement.textContent = localize('urlLengthError', "The data exceeds the length limit of 2081. The data is length {0}.", url.length);
show(lengthValidationElement);
return false;
} else {
hide(lengthValidationElement);
}
shell.openExternal(url);
return true;
}