Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Always reject Promises with Error instances

Browse Source
This commit is contained in:
Felix Becker
2017-06-19 19:35:58 +02:00
parent d0a6cc2715
commit dbe0f89264
63 changed files with 207 additions and 236 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/vs/workbench/api/electron-browser/mainThreadEditors.ts
View File

@@ -158,7 +158,7 @@ export class MainThreadEditors extends MainThreadEditorsShape {
$trySetSelections(id: string, selections: ISelection[]): TPromise<any> {
if (!this._documentsAndEditors.getEditor(id)) {
return TPromise.wrapError('TextEditor disposed');
return TPromise.wrapError(new Error('TextEditor disposed'));
}
this._documentsAndEditors.getEditor(id).setSelections(selections);
return TPromise.as(null);
@@ -166,7 +166,7 @@ export class MainThreadEditors extends MainThreadEditorsShape {
$trySetDecorations(id: string, key: string, ranges: IDecorationOptions[]): TPromise<any> {
if (!this._documentsAndEditors.getEditor(id)) {
return TPromise.wrapError('TextEditor disposed');
return TPromise.wrapError(new Error('TextEditor disposed'));
}
this._documentsAndEditors.getEditor(id).setDecorations(key, ranges);
return TPromise.as(null);
@@ -174,7 +174,7 @@ export class MainThreadEditors extends MainThreadEditorsShape {
$tryRevealRange(id: string, range: IRange, revealType: TextEditorRevealType): TPromise<any> {
if (!this._documentsAndEditors.getEditor(id)) {
return TPromise.wrapError('TextEditor disposed');
return TPromise.wrapError(new Error('TextEditor disposed'));
}
this._documentsAndEditors.getEditor(id).revealRange(range, revealType);
return undefined;
@@ -182,7 +182,7 @@ export class MainThreadEditors extends MainThreadEditorsShape {
$trySetOptions(id: string, options: ITextEditorConfigurationUpdate): TPromise<any> {
if (!this._documentsAndEditors.getEditor(id)) {
return TPromise.wrapError('TextEditor disposed');
return TPromise.wrapError(new Error('TextEditor disposed'));
}
this._documentsAndEditors.getEditor(id).setConfiguration(options);
return TPromise.as(null);
@@ -190,14 +190,14 @@ export class MainThreadEditors extends MainThreadEditorsShape {
$tryApplyEdits(id: string, modelVersionId: number, edits: ISingleEditOperation[], opts: IApplyEditsOptions): TPromise<boolean> {
if (!this._documentsAndEditors.getEditor(id)) {
return TPromise.wrapError<boolean>('TextEditor disposed');
return TPromise.wrapError<boolean>(new Error('TextEditor disposed'));
}
return TPromise.as(this._documentsAndEditors.getEditor(id).applyEdits(modelVersionId, edits, opts));
}
$tryInsertSnippet(id: string, template: string, ranges: IRange[], opts: IUndoStopOptions): TPromise<boolean> {
if (!this._documentsAndEditors.getEditor(id)) {
return TPromise.wrapError<boolean>('TextEditor disposed');
return TPromise.wrapError<boolean>(new Error('TextEditor disposed'));
}
return TPromise.as(this._documentsAndEditors.getEditor(id).insertSnippet(template, ranges, opts));
}
@@ -214,7 +214,7 @@ export class MainThreadEditors extends MainThreadEditorsShape {
const editor = this._documentsAndEditors.getEditor(id);
if (!editor) {
return TPromise.wrapError<ILineChange[]>('No such TextEditor');
return TPromise.wrapError<ILineChange[]>(new Error('No such TextEditor'));
}
const codeEditor = editor.getCodeEditor();