diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts index 6cfc6f60408..112c76139b7 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts @@ -14,6 +14,7 @@ suite('env-namespace', () => { assert.equal(typeof env.appName, 'string'); assert.equal(typeof env.machineId, 'string'); assert.equal(typeof env.sessionId, 'string'); + assert.equal(typeof env.shell, 'string'); }); test('env is readonly', function () { @@ -22,6 +23,7 @@ suite('env-namespace', () => { assert.throws(() => (env as any).appName = '234'); assert.throws(() => (env as any).machineId = '234'); assert.throws(() => (env as any).sessionId = '234'); + assert.throws(() => (env as any).shell = '234'); }); test('env.remoteName', function () { diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index 67b899a4313..00c92be9246 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -6079,6 +6079,12 @@ declare module 'vscode' { */ export const remoteName: string | undefined; + /** + * The detected default shell for the extension host, this is overridden by the + * `terminal.integrated.shell` setting for the extension host's platform. + */ + export const shell: string; + /** * Opens an *external* item, e.g. a http(s) or mailto-link, using the * default application. diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 183828a6860..1f376c0f99f 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -623,12 +623,6 @@ declare module 'vscode' { */ export const logLevel: LogLevel; - /** - * The detected default shell for the extension host, this is overridden by the - * `terminal.integrated.shell` setting for the extension host's platform. - */ - export const shell: string; - /** * An [event](#Event) that fires when the log level has changed. */ diff --git a/src/vs/workbench/api/node/extHost.api.impl.ts b/src/vs/workbench/api/node/extHost.api.impl.ts index bbb26a719e9..debcbce5d4c 100644 --- a/src/vs/workbench/api/node/extHost.api.impl.ts +++ b/src/vs/workbench/api/node/extHost.api.impl.ts @@ -258,7 +258,6 @@ export function createApiFactory( return extHostClipboard; }, get shell() { - checkProposedApiEnabled(extension); return extHostTerminalService.getDefaultShell(configProvider); }, openExternal(uri: URI) {