GitHub - add "Open on GitHub" to blame hover (#237514)

* WIP - saving my work

* Refactor hover rendering code

extensions/github/src/commands.ts

@@ -7,7 +7,7 @@ import * as vscode from 'vscode';
 import { API as GitAPI } from './typings/git';
 import { publishRepository } from './publish';
 import { DisposableStore } from './util';
-import { LinkContext, getLink, getVscodeDevHost } from './links';
+import { LinkContext, getCommitLink, getLink, getVscodeDevHost } from './links';
 
 async function copyVscodeDevLink(gitAPI: GitAPI, useSelection: boolean, context: LinkContext, includeRange = true) {
 	try {
@@ -57,6 +57,11 @@ export function registerCommands(gitAPI: GitAPI): vscode.Disposable {
 		return copyVscodeDevLink(gitAPI, true, context, false);
 	}));
 
+	disposables.add(vscode.commands.registerCommand('github.openOnGitHub', async (url: string, historyItemId: string) => {
+		const link = getCommitLink(url, historyItemId);
+		vscode.env.openExternal(vscode.Uri.parse(link));
+	}));
+
 	disposables.add(vscode.commands.registerCommand('github.openOnVscodeDev', async () => {
 		return openVscodeDevLink(gitAPI);
 	}));

extensions/github/src/links.ts

@@ -186,6 +186,15 @@ export function getBranchLink(url: string, branch: string, hostPrefix: string =
 	return `${hostPrefix}/${repo.owner}/${repo.repo}/tree/${branch}`;
 }
 
+export function getCommitLink(url: string, hash: string, hostPrefix: string = 'https://github.com') {
+	const repo = getRepositoryFromUrl(url);
+	if (!repo) {
+		throw new Error('Invalid repository URL provided');
+	}
+
+	return `${hostPrefix}/${repo.owner}/${repo.repo}/commit/${hash}`;
+}
+
 export function getVscodeDevHost(): string {
 	return `https://${vscode.env.appName.toLowerCase().includes('insiders') ? 'insiders.' : ''}vscode.dev/github`;
 }

extensions/github/src/remoteSourceProvider.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { Uri, env, l10n, workspace } from 'vscode';
+import { Command, Uri, env, l10n, workspace } from 'vscode';
 import { RemoteSourceProvider, RemoteSource, RemoteSourceAction } from './typings/git-base';
 import { getOctokit } from './auth';
 import { Octokit } from '@octokit/rest';
@@ -136,4 +136,18 @@ export class GithubRemoteSourceProvider implements RemoteSourceProvider {
 			}
 		}];
 	}
+
+	async getRemoteSourceControlHistoryItemCommands(url: string): Promise<Command[]> {
+		const repository = getRepositoryFromUrl(url);
+		if (!repository) {
+			return [];
+		}
+
+		return [{
+			title: l10n.t('{0} Open on GitHub', '$(github)'),
+			tooltip: l10n.t('Open on GitHub'),
+			command: 'github.openOnGitHub',
+			arguments: [url]
+		}];
+	}
 }

extensions/github/src/typings/git-base.d.ts

@@ -3,11 +3,13 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { Disposable, Event, ProviderResult, Uri } from 'vscode';
+import { Command, Disposable, Event, ProviderResult } from 'vscode';
 export { ProviderResult } from 'vscode';
 
 export interface API {
 	registerRemoteSourceProvider(provider: RemoteSourceProvider): Disposable;
+	getRemoteSourceActions(url: string): Promise<RemoteSourceAction[]>;
+	getRemoteSourceControlHistoryItemCommands(url: string): Promise<Command[]>;
 	pickRemoteSource(options: PickRemoteSourceOptions): Promise<string | PickRemoteSourceResult | undefined>;
 }
 
@@ -80,6 +82,7 @@ export interface RemoteSourceProvider {
 
 	getBranches?(url: string): ProviderResult<string[]>;
 	getRemoteSourceActions?(url: string): ProviderResult<RemoteSourceAction[]>;
+	getRemoteSourceControlHistoryItemCommands?(url: string): ProviderResult<Command[]>;
 	getRecentRemoteSources?(query?: string): ProviderResult<RecentRemoteSource[]>;
 	getRemoteSources(query?: string): ProviderResult<RemoteSource[]>;
 }