From dcb5998b75c845a2b3ce1fcb480eceec836c6608 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 23 Jan 2020 10:00:50 -0800 Subject: [PATCH] Fix resource scope access error logging (#89130) For #87768 It seems that this log message is meant to be fired when accessing a resource scoped config without a resource --- src/vs/workbench/api/common/extHostConfiguration.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHostConfiguration.ts b/src/vs/workbench/api/common/extHostConfiguration.ts index a8320d19b0e..b4aad76159e 100644 --- a/src/vs/workbench/api/common/extHostConfiguration.ts +++ b/src/vs/workbench/api/common/extHostConfiguration.ts @@ -301,7 +301,7 @@ export class ExtHostConfigProvider { const scope = OVERRIDE_PROPERTY_PATTERN.test(key) ? ConfigurationScope.RESOURCE : this._configurationScopes.get(key); const extensionIdText = extensionId ? `[${extensionId.value}] ` : ''; if (ConfigurationScope.RESOURCE === scope) { - if (overrides?.resource) { + if (typeof overrides?.resource === 'undefined') { this._logService.warn(`${extensionIdText}Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '${key}', provide the URI of a resource or 'null' for any resource.`); } return;