Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 11:08:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

improve revert logic for untitled (also dispose untitled input after save)

Browse Source
This commit is contained in:
Benjamin Pasero
2016-06-06 16:20:12 +02:00
parent 483c63bc0c
commit dcd7c87af5
12 changed files with 61 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/common/editor/untitledEditorInput.ts
View File

@@ -58,7 +58,7 @@ export class UntitledEditorInput extends AbstractUntitledEditorInput {
}
private registerListeners(): void {
this.toUnbind.push(this.eventService.addListener2(WorkbenchEventType.UNTITLED_FILE_DELETED, (e: UntitledEditorEvent) => this.onDirtyStateChange(e)));
this.toUnbind.push(this.eventService.addListener2(WorkbenchEventType.UNTITLED_FILE_SAVED, (e: UntitledEditorEvent) => this.onDirtyStateChange(e)));
this.toUnbind.push(this.eventService.addListener2(WorkbenchEventType.UNTITLED_FILE_DIRTY, (e: UntitledEditorEvent) => this.onDirtyStateChange(e)));
}
@@ -97,7 +97,9 @@ export class UntitledEditorInput extends AbstractUntitledEditorInput {
}
public revert(): TPromise<boolean> {
return this.textFileService.revert(this.resource);
this.cachedModel.revert();
return TPromise.as(true);
}
public suggestFileName(): string {
@@ -179,15 +181,15 @@ export class UntitledEditorInput extends AbstractUntitledEditorInput {
public dispose(): void {
// Listeners
dispose(this.toUnbind);
// Model
if (this.cachedModel) {
this.cachedModel.dispose();
this.cachedModel = null;
}
// Listeners
dispose(this.toUnbind);
super.dispose();
}
}