Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 09:08:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Markdown reference links starting with ^ should not be clickable (#108015)

Browse Source 
Co-authored-by: mmacovei <mmacovei@sfu.ca>
This commit is contained in:
Nafana
2020-10-07 23:38:17 -07:00
committed by GitHub
parent 57fc7c21ac
commit df59ceb026
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/markdown-language-features/src/features/documentLinkProvider.ts
+1 -1
View File
@@ -105,7 +105,7 @@ function extractDocumentLink(
export default class LinkProvider implements vscode.DocumentLinkProvider {
private readonly linkPattern = /(\[((!\[[^\]]*?\]\(\s*)([^\s\(\)]+?)\s*\)\]|(?:\\\]|[^\]])*\])\(\s*)(([^\s\(\)]|\(\S*?\))+)\s*(".*?")?\)/g;
private readonly referenceLinkPattern = /(\[((?:\\\]|[^\]])+)\]\[\s*?)([^\s\]]*?)\]/g;
private readonly definitionPattern = /^([\t ]*\[((?:\\\]|[^\]])+)\]:\s*)(\S+)/gm;
private readonly definitionPattern = /^([\t ]*\[(?!\^)((?:\\\]|[^\]])+)\]:\s*)(\S+)/gm;
public provideDocumentLinks(
document: vscode.TextDocument,
extensions/markdown-language-features/src/test/documentLinkProvider.test.ts
+6
View File
@@ -138,6 +138,12 @@ suite('markdown.DocumentLinkProvider', () => {
assertRangeEqual(link4.range, new vscode.Range(0, 50, 0, 59));
}
});
// #107471
test('Should not consider link references starting with ^ character valid', () => {
const links = getLinksForFile('[^reference]: https://example.com');
assert.strictEqual(links.length, 0);
});
});