From e05aa178d6996d6ff7cb5dbbbfb75d3b95d13212 Mon Sep 17 00:00:00 2001 From: Prabhanjan S Koushik Date: Thu, 29 Nov 2018 22:39:36 +0530 Subject: [PATCH] Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..." (#63936) * fix-63749 - Added UNICODE_NEWLINE_REGEX * fix-63749 - Removed .skip for the test method * fix-63749 Moved Replace to parse --- extensions/markdown-language-features/src/markdownEngine.ts | 3 ++- .../src/test/documentSymbolProvider.test.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/extensions/markdown-language-features/src/markdownEngine.ts b/extensions/markdown-language-features/src/markdownEngine.ts index 9bd90ead16a..35b8d19495d 100644 --- a/extensions/markdown-language-features/src/markdownEngine.ts +++ b/extensions/markdown-language-features/src/markdownEngine.ts @@ -109,13 +109,14 @@ export class MarkdownEngine { } public async parse(document: vscode.Uri, source: string): Promise { + const UNICODE_NEWLINE_REGEX = /\u2028|\u2029/g; const { text, offset } = this.stripFrontmatter(source); this.currentDocument = document; this._slugCount = new Map(); const engine = await this.getEngine(document); - return engine.parse(text, {}).map(token => { + return engine.parse(text.replace(UNICODE_NEWLINE_REGEX, ''), {}).map(token => { if (token.map) { token.map[0] += offset; token.map[1] += offset; diff --git a/extensions/markdown-language-features/src/test/documentSymbolProvider.test.ts b/extensions/markdown-language-features/src/test/documentSymbolProvider.test.ts index 9df272ccecd..483c8395db0 100644 --- a/extensions/markdown-language-features/src/test/documentSymbolProvider.test.ts +++ b/extensions/markdown-language-features/src/test/documentSymbolProvider.test.ts @@ -83,7 +83,7 @@ suite('markdown.DocumentSymbolProvider', () => { assert.strictEqual(symbols[0].children[1].name, '## h3'); }); - test.skip('Should handle line separator in file. Issue #63749', async () => { + test('Should handle line separator in file. Issue #63749', async () => { const symbols = await getSymbolsForFile(`# A - foo