diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts index 50ef55b4f55..2a149aa2e1a 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts @@ -660,7 +660,7 @@ suite('window namespace tests', () => { test('TerminalRenderer.write should fire Terminal.onData', (done) => { const reg1 = window.onDidOpenTerminal(terminal => { reg1.dispose(); - const reg2 = terminal.onData(data => { + const reg2 = terminal.onDidWriteData(data => { assert.equal(data, 'bar'); reg2.dispose(); const reg3 = window.onDidCloseTerminal(() => { @@ -677,7 +677,7 @@ suite('window namespace tests', () => { test('Terminal.sendText should fire Termnial.onInput', (done) => { const reg1 = window.onDidOpenTerminal(terminal => { reg1.dispose(); - const reg2 = renderer.onInput(data => { + const reg2 = renderer.onDidAcceptInput(data => { assert.equal(data, 'bar'); reg2.dispose(); const reg3 = window.onDidCloseTerminal(() => { diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 04d85d9ed84..737e1b91bdf 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -341,7 +341,7 @@ declare module 'vscode' { * provides access to the raw data stream from the process running within the terminal, * including VT sequences. */ - onData: Event; + onDidWriteData: Event; } /** @@ -368,10 +368,10 @@ declare module 'vscode' { * created with all its APIs available for use by extensions. When using the Terminal object * of a TerminalRenderer it acts just like normal only the extension that created the * TerminalRenderer essentially acts as a process. For example when an - * [Terminal.onData](#Terminal.onData) listener is registered, that will fire when - * [TerminalRenderer.write](#TerminalRenderer.write) is called. Similarly when + * [Terminal.onDidWriteData](#Terminal.onDidWriteData) listener is registered, that will fire + * when [TerminalRenderer.write](#TerminalRenderer.write) is called. Similarly when * [Terminal.sendText](#Terminal.sendText) is triggered that will fire the - * [TerminalRenderer.onInput](#TerminalRenderer.onInput) event. + * [TerminalRenderer.onDidAcceptInput](#TerminalRenderer.onDidAcceptInput) event. * * **Example:** Create a terminal renderer, show it and write hello world in red * ```typescript @@ -441,13 +441,13 @@ declare module 'vscode' { * workbench command such as `workbench.action.terminal.runSelectedText` * ```typescript * const terminalRenderer = window.createTerminalRenderer('test'); - * terminalRenderer.onInput(data => { + * terminalRenderer.onDidAcceptInput(data => { * cosole.log(data); // 'Hello world' * }); * terminalRenderer.terminal.then(t => t.sendText('Hello world')); * ``` */ - onInput: Event; + onDidAcceptInput: Event; /** * An event which fires when the [maximum dimensions](#TerminalRenderer.maimumDimensions) of diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index e4f5405418c..4c16f048f99 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -77,7 +77,7 @@ export class ExtHostTerminal extends BaseExtHostTerminal implements vscode.Termi private _pidPromiseComplete: (value: number) => any; private readonly _onData: Emitter = new Emitter(); - public get onData(): Event { + public get onDidWriteData(): Event { // Tell the main side to start sending data if it's not already this._proxy.$registerOnDataListener(this._id); return this._onData && this._onData.event; @@ -156,7 +156,7 @@ export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vsco } private readonly _onInput: Emitter = new Emitter(); - public get onInput(): Event { + public get onDidAcceptInput(): Event { this._checkDisposed(); this._queueApiRequest(this._proxy.$terminalRendererRegisterOnInputListener, [this._id]); // Tell the main side to start sending data if it's not already