From e120edc2f7d6e03d97fb98d21db669e7efd492bb Mon Sep 17 00:00:00 2001 From: Murat Aslan Date: Fri, 2 Jan 2026 17:42:15 +0300 Subject: [PATCH] chore: remove stale TODOs about lifecycle hack --- src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts b/src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts index c60ec3a8a96e..1e6a52f9e043 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts @@ -592,10 +592,8 @@ export class TerminalTabbedView extends Disposable { // be focused. So wait for connection to finish, then focus. const previousActiveElement = this._tabListElement.ownerDocument.activeElement; if (previousActiveElement) { - // TODO: Improve lifecycle management this event should be disposed after first fire const listener = this._register(Event.once(this._terminalService.onDidChangeConnectionState)(() => { // Only focus the terminal if the activeElement has not changed since focus() was called - // TODO: Hack if (dom.isActiveElement(previousActiveElement)) { this._focus(); }