From e151ba5aca1227cdebeb57ea1e6cbea80bb16872 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Mon, 14 Aug 2023 15:21:37 -0700 Subject: [PATCH] clean up --- .../workbench/contrib/terminal/browser/xterm/xtermTerminal.ts | 4 ++-- .../contrib/terminal/test/browser/xterm/xtermTerminal.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts b/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts index 4f2544ef375..c005695a661 100644 --- a/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts +++ b/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts @@ -284,11 +284,11 @@ export class XtermTerminal extends DisposableStore implements IXtermTerminal, ID if (!textArea) { return; } - // Sync the textarea using shell integration so screen - // readers can review the command with left/ right arrow keys + // Sync the textarea using shell integration textArea.textContent = data.content; textArea.selectionStart = data.cursorX; textArea.selectionEnd = data.cursorX; + // TODO: cursorY? })); this._anyTerminalFocusContextKey = TerminalContextKeys.focusInAny.bindTo(contextKeyService); diff --git a/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts b/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts index 42e1bc592dd..ab689e76e87 100644 --- a/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts +++ b/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts @@ -51,7 +51,7 @@ class TestWebglAddon implements WebglAddon { } clearTextureAtlas() { } } -// to + class TestXtermTerminal extends XtermTerminal { webglAddonPromise: Promise = Promise.resolve(TestWebglAddon); // Force synchronous to avoid async when activating the addon