Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Tweak WebviewPanelOnDidChangeViewStateEvent to only provide a webview panel

Browse Source 
Expose a webview panel's view state as properties. Make WebviewPanelOnDidChangeViewStateEvent only fire an event with the webview who's state changed
This commit is contained in:
Matt Bierner
2018-04-12 14:22:26 -07:00
parent 23113a4443
commit e16ec3c1ff
3 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/node/extHostWebview.ts
View File

@@ -97,7 +97,7 @@ export class ExtHostWebviewPanel implements vscode.WebviewPanel {
private readonly _proxy: MainThreadWebviewsShape;
private _isDisposed: boolean = false;
private _viewColumn: vscode.ViewColumn;
private _active: boolean;
private _visible: boolean;
public readonly onDisposeEmitter = new Emitter<void>();
public readonly onDidDispose: Event<void> = this.onDisposeEmitter.event;
@@ -155,9 +155,9 @@ export class ExtHostWebviewPanel implements vscode.WebviewPanel {
return this._viewColumn;
}
get active(): boolean {
get visible(): boolean {
this.assertNotDisposed();
return this._active;
return this._visible;
}
set viewColumn(value: vscode.ViewColumn) {
@@ -167,7 +167,7 @@ export class ExtHostWebviewPanel implements vscode.WebviewPanel {
set active(value: boolean) {
this.assertNotDisposed();
this._active = value;
this._visible = value;
}
public postMessage(message: any): Thenable<boolean> {
@@ -247,7 +247,7 @@ export class ExtHostWebviews implements ExtHostWebviewsShape {
if (panel.active !== active || panel.viewColumn !== viewColumn) {
panel.active = active;
panel.viewColumn = viewColumn;
panel.onDidChangeViewStateEmitter.fire({ active, viewColumn });
panel.onDidChangeViewStateEmitter.fire({ webviewPanel: panel });
}
}
}