Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-14 23:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Agent session mode breaks the tri-state toggle of the chat icon in the title bar (fix #291099) (#291243)

Browse Source 
* Agent session mode breaks the tri-state toggle of the chat icon in the title bar (fix #291099)

* copilot feedback

* .
This commit is contained in:
Benjamin Pasero
2026-01-28 11:56:49 +01:00
committed by GitHub
parent 36a463fd5e
commit e1cede2ffc
3 changed files with 36 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts
View File

@@ -508,25 +508,41 @@ export function registerChatActions() {
const configurationService = accessor.get(IConfigurationService);
const chatLocation = viewDescriptorService.getViewLocationById(ChatViewId);
const chatVisible = viewsService.isViewVisible(ChatViewId);
const clickBehavior = configurationService.getValue<AgentsControlClickBehavior>(ChatConfiguration.AgentsControlClickBehavior);
if (viewsService.isViewVisible(ChatViewId)) {
if (clickBehavior === AgentsControlClickBehavior.Focus) {
(await widgetService.revealWidget())?.focusInput();
} else {
if (
chatLocation === ViewContainerLocation.AuxiliaryBar &&
!layoutService.isAuxiliaryBarMaximized() &&
clickBehavior === AgentsControlClickBehavior.TriStateToggle
) {
switch (clickBehavior) {
case AgentsControlClickBehavior.Focus:
if (chatLocation === ViewContainerLocation.AuxiliaryBar) {
layoutService.setAuxiliaryBarMaximized(true);
} else {
this.updatePartVisibility(layoutService, chatLocation, false);
this.updatePartVisibility(layoutService, chatLocation, true);
}
}
} else {
this.updatePartVisibility(layoutService, chatLocation, true);
(await widgetService.revealWidget())?.focusInput();
(await widgetService.revealWidget())?.focusInput();
break;
case AgentsControlClickBehavior.Cycle:
if (chatVisible) {
if (
chatLocation === ViewContainerLocation.AuxiliaryBar &&
!layoutService.isAuxiliaryBarMaximized()
) {
layoutService.setAuxiliaryBarMaximized(true);
(await widgetService.revealWidget())?.focusInput();
} else {
this.updatePartVisibility(layoutService, chatLocation, false);
}
} else {
this.updatePartVisibility(layoutService, chatLocation, true);
(await widgetService.revealWidget())?.focusInput();
}
break;
default:
if (chatVisible) {
this.updatePartVisibility(layoutService, chatLocation, false);
} else {
this.updatePartVisibility(layoutService, chatLocation, true);
(await widgetService.revealWidget())?.focusInput();
}
break;
}
}

8
src/vs/workbench/contrib/chat/browser/chat.contribution.ts
View File

@@ -188,14 +188,14 @@ configurationRegistry.registerConfiguration({
},
[ChatConfiguration.AgentsControlClickBehavior]: {
type: 'string',
enum: [AgentsControlClickBehavior.Default, AgentsControlClickBehavior.TriStateToggle, AgentsControlClickBehavior.Focus],
enum: [AgentsControlClickBehavior.Default, AgentsControlClickBehavior.Cycle, AgentsControlClickBehavior.Focus],
enumDescriptions: [
nls.localize('chat.agentsControl.clickBehavior.default', "Clicking chat icon toggles chat visibility."),
nls.localize('chat.agentsControl.clickBehavior.triStateToggle', "Clicking chat icon cycles through: show chat, maximize chat, hide chat. This requires chat to be contained in the secondary sidebar."),
nls.localize('chat.agentsControl.clickBehavior.focus', "Clicking chat icon focuses the chat view.")
nls.localize('chat.agentsControl.clickBehavior.cycle', "Clicking chat icon cycles through: show chat, maximize chat, hide chat. This requires chat to be contained in the secondary sidebar."),
nls.localize('chat.agentsControl.clickBehavior.focus', "Clicking chat icon focuses the chat view and maximizes it if located in the secondary sidebar.")
],
markdownDescription: nls.localize('chat.agentsControl.clickBehavior', "Controls the behavior when clicking on the chat icon in the command center."),
default: product.quality !== 'stable' ? AgentsControlClickBehavior.TriStateToggle : AgentsControlClickBehavior.Default,
default: product.quality !== 'stable' ? AgentsControlClickBehavior.Cycle : AgentsControlClickBehavior.Default,
tags: ['experimental']
},
[ChatConfiguration.AgentStatusEnabled]: {

2
src/vs/workbench/contrib/chat/common/constants.ts
View File

@@ -84,7 +84,7 @@ export enum CollapsedToolsDisplayMode {
export enum AgentsControlClickBehavior {
Default = 'default',
TriStateToggle = 'triStateToggle',
Cycle = 'cycle',
Focus = 'focus',
}