Implement creating a razzle terminal with approved API changes

This commit is contained in:
Gabriel DeBacker
2019-01-11 10:27:18 -08:00
parent 14ce5183db
commit e1d8493f28
6 changed files with 50 additions and 22 deletions

View File

@@ -55,7 +55,7 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape
// when the extension host process goes down ?
}
public $createTerminal(name?: string, shellPath?: string, shellArgs?: string[], cwd?: string, env?: { [key: string]: string }, waitOnExit?: boolean): Promise<{ id: number, name: string }> {
public $createTerminal(name?: string, shellPath?: string, shellArgs?: string[], cwd?: string, env?: { [key: string]: string }, waitOnExit?: boolean, strictEnv?: boolean): Promise<{ id: number, name: string }> {
const shellLaunchConfig: IShellLaunchConfig = {
name,
executable: shellPath,
@@ -63,7 +63,8 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape
cwd,
waitOnExit,
ignoreConfigurationCwd: true,
env
env,
strictEnv
};
const terminal = this.terminalService.createTerminal(shellLaunchConfig);
return Promise.resolve({