Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add override keyword in codebase (#120755)

Browse Source 
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
This commit is contained in:
Matt Bierner
2021-04-08 10:05:20 -07:00
committed by GitHub
parent 604b950f0d
commit e1f0f8f513
541 changed files with 1965 additions and 1965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/common/extHostTesting.ts
View File

@@ -486,14 +486,14 @@ class MirroredChangeCollector extends IncrementalChangeCollector<MirroredCollect
/**
* @override
*/
public add(node: MirroredCollectionTestItem): void {
public override add(node: MirroredCollectionTestItem): void {
this.added.add(node);
}
/**
* @override
*/
public update(node: MirroredCollectionTestItem): void {
public override update(node: MirroredCollectionTestItem): void {
Object.assign(node.revived, Convert.TestItem.toPlain(node.item));
if (!this.added.has(node)) {
this.updated.add(node);
@@ -503,7 +503,7 @@ class MirroredChangeCollector extends IncrementalChangeCollector<MirroredCollect
/**
* @override
*/
public remove(node: MirroredCollectionTestItem): void {
public override remove(node: MirroredCollectionTestItem): void {
if (this.added.has(node)) {
this.added.delete(node);
return;
@@ -531,7 +531,7 @@ class MirroredChangeCollector extends IncrementalChangeCollector<MirroredCollect
};
}
public complete() {
public override complete() {
if (!this.isEmpty) {
this.emitter.fire(this.getChangeEvent());
}
@@ -603,7 +603,7 @@ export class MirroredTestCollection extends AbstractIncrementalTestCollection<Mi
/**
* @override
*/
protected createChangeCollector() {
protected override createChangeCollector() {
return new MirroredChangeCollector(this.changeEmitter);
}
}