Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 03:29:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add override keyword in codebase (#120755)

Browse Source 
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
This commit is contained in:
Matt Bierner
2021-04-08 10:05:20 -07:00
committed by GitHub
parent 604b950f0d
commit e1f0f8f513
541 changed files with 1965 additions and 1965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/services/userDataSync/browser/userDataAutoSyncEnablementService.ts
View File

@@ -13,11 +13,11 @@ export class WebUserDataAutoSyncEnablementService extends UserDataAutoSyncEnable
private get workbenchEnvironmentService(): IWorkbenchEnvironmentService { return <IWorkbenchEnvironmentService>this.environmentService; }
private enabled: boolean | undefined = undefined;
canToggleEnablement(): boolean {
override canToggleEnablement(): boolean {
return this.isTrusted() && super.canToggleEnablement();
}
isEnabled(): boolean {
override isEnabled(): boolean {
if (!this.isTrusted()) {
return false;
}
@@ -30,7 +30,7 @@ export class WebUserDataAutoSyncEnablementService extends UserDataAutoSyncEnable
return this.enabled;
}
setEnablement(enabled: boolean) {
override setEnablement(enabled: boolean) {
if (enabled && !this.canToggleEnablement()) {
return;
}

2
src/vs/workbench/services/userDataSync/browser/userDataSyncResourceEnablementService.ts
View File

@@ -20,7 +20,7 @@ export class UserDataSyncResourceEnablementService extends BaseUserDataSyncResou
super(storageService, telemetryService);
}
getResourceSyncStateVersion(resource: SyncResource): string | undefined {
override getResourceSyncStateVersion(resource: SyncResource): string | undefined {
return resource === SyncResource.Extensions ? this.environmentService.options?.settingsSyncOptions?.extensionsSyncStateVersion : undefined;
}