Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-30 05:21:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #29802 Corner cases of Select next/prev item feature

Browse Source
This commit is contained in:
Ramya Achutha Rao
2017-06-28 15:30:33 -07:00
parent 9cb698b16f
commit e2a18e4b6d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/emmet/src/selectItemHTML.ts
View File

@@ -13,7 +13,7 @@ export function nextItemHTML(selectionStart: vscode.Position, selectionEnd: vsco
if (currentNode.type !== 'comment') {
// If cursor is in the tag name, select tag
if (selectionEnd.translate(0, -currentNode.name.length).isBefore(currentNode.open.start)) {
if (selectionEnd.isBefore(currentNode.open.start.translate(0, currentNode.name.length))) {
return getSelectionFromNode(currentNode, editor.document);
}
@@ -113,7 +113,7 @@ function getNextAttribute(selectionStart: vscode.Position, selectionEnd: vscode.
return new vscode.Selection(attr.start, attr.end);
}
if ((<vscode.Position>attr.value.start).isEqual(attr.value.end)) {
if (!attr.value || (<vscode.Position>attr.value.start).isEqual(attr.value.end)) {
// No attr value to select
continue;
}
@@ -163,7 +163,7 @@ function getPrevAttribute(selectionStart: vscode.Position, selectionEnd: vscode.
continue;
}
if ((<vscode.Position>attr.value.start).isEqual(attr.value.end) || selectionStart.isBefore(attr.value.start)) {
if (!attr.value || (<vscode.Position>attr.value.start).isEqual(attr.value.end) || selectionStart.isBefore(attr.value.start)) {
// select full attr
return new vscode.Selection(attr.start, attr.end);
}