From e3f266fae27717677cf98dba5d360b4b85fb95cd Mon Sep 17 00:00:00 2001 From: Bhavya U Date: Sun, 22 Sep 2024 21:36:54 -0700 Subject: [PATCH] Fix welcome page "Go Back" (#229328) --- .../welcomeGettingStarted/browser/gettingStarted.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts b/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts index b2cee02873c..4641275f880 100644 --- a/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts +++ b/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts @@ -902,7 +902,7 @@ export class GettingStartedPage extends EditorPane { this.currentWalkthrough = first; this.editorInput.selectedCategory = this.currentWalkthrough?.id; this.buildCategorySlide(this.editorInput.selectedCategory, undefined); - this.setSlide('details'); + this.setSlide('details', true /* firstLaunch */); return; } } @@ -1542,7 +1542,7 @@ export class GettingStartedPage extends EditorPane { } } - private setSlide(toEnable: 'details' | 'categories') { + private setSlide(toEnable: 'details' | 'categories', firstLaunch: boolean = false) { const slideManager = assertIsDefined(this.container.querySelector('.gettingStarted')); if (toEnable === 'categories') { slideManager.classList.remove('showDetails'); @@ -1554,8 +1554,12 @@ export class GettingStartedPage extends EditorPane { } else { slideManager.classList.add('showDetails'); slideManager.classList.remove('showCategories'); - const showGoBackButton = this.editorInput.showWelcome || this.prevWalkthrough; - this.container.querySelector('.prev-button.button-link')!.style.display = showGoBackButton ? 'block' : 'none'; + const prevButton = this.container.querySelector('.prev-button.button-link'); + prevButton!.style.display = this.editorInput.showWelcome || this.prevWalkthrough ? 'block' : 'none'; + + const moreTextElement = prevButton!.querySelector('.moreText'); + moreTextElement!.textContent = firstLaunch ? localize('welcome', "Welcome") : localize('goBack', "Go Back"); + this.container.querySelector('.gettingStartedSlideDetails')!.querySelectorAll('button').forEach(button => button.disabled = false); this.container.querySelector('.gettingStartedSlideCategories')!.querySelectorAll('button').forEach(button => button.disabled = true); this.container.querySelector('.gettingStartedSlideCategories')!.querySelectorAll('input').forEach(button => button.disabled = true);