Webview panels start out as visible

This commit is contained in:
Matt Bierner
2018-04-13 17:32:22 -07:00
parent 71c09a6c4c
commit e4c975592b

View File

@@ -97,7 +97,7 @@ export class ExtHostWebviewPanel implements vscode.WebviewPanel {
private readonly _proxy: MainThreadWebviewsShape;
private _isDisposed: boolean = false;
private _viewColumn: vscode.ViewColumn;
private _visible: boolean;
private _visible: boolean = true;
public readonly onDisposeEmitter = new Emitter<void>();
public readonly onDidDispose: Event<void> = this.onDisposeEmitter.event;
@@ -242,12 +242,12 @@ export class ExtHostWebviews implements ExtHostWebviewsShape {
}
}
$onDidChangeWebviewViewState(handle: WebviewHandle, active: boolean, position: Position): void {
$onDidChangeWebviewViewState(handle: WebviewHandle, visible: boolean, position: Position): void {
const panel = this.getWebviewPanel(handle);
if (panel) {
const viewColumn = typeConverters.toViewColumn(position);
if (panel.visible !== active || panel.position !== viewColumn) {
panel.visible = active;
if (panel.visible !== visible || panel.position !== viewColumn) {
panel.visible = visible;
panel.position = viewColumn;
panel.onDidChangeViewStateEmitter.fire({ webviewPanel: panel });
}