Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 10:38:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Treat comma as a commit character in js / ts

Browse Source 
Fixes #52351
This commit is contained in:
Matt Bierner
2018-06-19 11:51:09 -07:00
parent 0e361509ef
commit e4fe04ad5b
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
extensions/typescript-language-features/src/features/completions.ts
View File

@@ -148,6 +148,7 @@ class MyCompletionItem extends vscode.CompletionItem {
enableCallCompletions: boolean,
kind: string
): string[] | undefined {
const commitCharacters: string[] = [];
switch (kind) {
case PConst.Kind.memberGetAccessor:
case PConst.Kind.memberSetAccessor:
@@ -156,7 +157,10 @@ class MyCompletionItem extends vscode.CompletionItem {
case PConst.Kind.indexSignature:
case PConst.Kind.enum:
case PConst.Kind.interface:
return enableDotCompletions ? ['.'] : undefined;
if (enableDotCompletions) {
commitCharacters.push('.');
}
break;
case PConst.Kind.module:
case PConst.Kind.alias:
@@ -168,10 +172,16 @@ class MyCompletionItem extends vscode.CompletionItem {
case PConst.Kind.class:
case PConst.Kind.function:
case PConst.Kind.memberFunction:
return enableDotCompletions ? (enableCallCompletions ? ['.', '('] : ['.']) : undefined;
if (enableDotCompletions) {
commitCharacters.push('.', ',');
}
if (enableCallCompletions) {
commitCharacters.push('(');
}
break;
}
return undefined;
return commitCharacters.length === 0 ? undefined : commitCharacters;
}
}