From e6efb0b4a91190d9a95b896d80c8ef0239c8c8ea Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 8 Jun 2021 05:21:52 -0700 Subject: [PATCH] Set terminal title in ctor for custom pty terminals Fixes #125729 --- .../workbench/contrib/terminal/browser/terminalInstance.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 4bcb9ca5da8..611101f0046 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -281,6 +281,12 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { this._terminalProfileResolverService.resolveIcon(this._shellLaunchConfig, OS); } + // When a custom pty is used set the name immediately so it gets passed over to the exthost + // and is available when Pseudoterminal.open fires. + if (this.shellLaunchConfig.customPtyImplementation) { + this.setTitle(this._shellLaunchConfig.name, TitleEventSource.Api); + } + this._initDimensions(); this._createProcessManager();