Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Separate Settings editor open and search steps" (#196997)

Browse Source 
Revert "Separate Settings editor open and search steps (#196866)"

This reverts commit 932e49579b.
This commit is contained in:
Raymond Zhao
2023-10-30 09:53:19 -07:00
committed by GitHub
parent 67b2b79aba
commit e9e1f8a132
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/smoke/src/areas/preferences/preferences.test.ts
View File

@@ -42,7 +42,6 @@ export function setup(logger: Logger) {
it('shows a modified indicator on a modified setting', async function () {
const app = this.app as Application;
await app.workbench.settingsEditor.openUserSettingsUI();
await app.workbench.settingsEditor.searchSettingsUI('@id:editor.tabSize');
await app.code.waitForSetValue('.settings-editor .setting-item-contents .setting-item-control input', '6');
await app.code.waitForElement('.settings-editor .setting-item-contents .setting-item-modified-indicator');
@@ -57,7 +56,6 @@ export function setup(logger: Logger) {
await app.code.waitForElements('.line-numbers', false, elements => !!elements.length);
// Turn off line numbers
await app.workbench.settingsEditor.openUserSettingsUI();
await app.workbench.settingsEditor.searchSettingsUI('editor.lineNumbers');
await app.code.waitAndClick('.settings-editor .monaco-list-rows .setting-item-control select', 2, 2);
await app.code.waitAndClick('.context-view .option-text', 2, 2);
@@ -66,11 +64,10 @@ export function setup(logger: Logger) {
await app.code.waitForElements('.line-numbers', false, elements => !elements || elements.length === 0);
});
it('hides the toc when searching depending on the search behavior', async function () {
// Skipping test due to it being flaky.
it.skip('hides the toc when searching depending on the search behavior', async function () {
const app = this.app as Application;
await app.workbench.settingsEditor.openUserSettingsUI();
// Hide ToC when searching
await app.workbench.settingsEditor.searchSettingsUI('workbench.settings.settingsSearchTocBehavior');
await app.code.waitAndClick('.settings-editor .monaco-list-rows .setting-item-control select', 2, 2);