Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 00:59:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

chat: add requestNeedsInput on the chat model (#278171)

Browse Source 
With a side quest that makes elicitations correctly trigger this, which
involved refactoring their state into an observable.

Also swap requestInProgress/Obs to a single requestInProgress observable.
Synchronous callers can just `.get()` it as needed.
This commit is contained in:
Connor Peet
2025-11-18 11:05:28 -08:00
committed by GitHub
parent 81189ec6d1
commit ea4ccd5f44
23 changed files with 136 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts
View File

@@ -565,7 +565,7 @@ export class InlineChatController1 implements IEditorContribution {
}
options.position = await this._strategy.renderChanges();
if (this._session.chatModel.requestInProgress) {
if (this._session.chatModel.requestInProgress.get()) {
return State.SHOW_REQUEST;
} else {
return State.WAIT_FOR_INPUT;
@@ -647,7 +647,7 @@ export class InlineChatController1 implements IEditorContribution {
private async [State.SHOW_REQUEST](options: InlineChatRunOptions): Promise<State.WAIT_FOR_INPUT | State.CANCEL | State.PAUSE | State.ACCEPT> {
assertType(this._session);
assertType(this._strategy);
assertType(this._session.chatModel.requestInProgress);
assertType(this._session.chatModel.requestInProgress.get());
this._ctxRequestInProgress.set(true);
@@ -1429,7 +1429,7 @@ export class InlineChatController2 implements IEditorContribution {
entry?.enableReviewModeUntilSettled();
}
const inProgress = session.chatModel.requestInProgressObs.read(r);
const inProgress = session.chatModel.requestInProgress.read(r);
this._zone.value.widget.domNode.classList.toggle('request-in-progress', inProgress);
if (!inProgress) {
this._zone.value.widget.chatWidget.setInputPlaceholder(localize('placeholder', "Edit, refactor, and generate code"));